Do not purge undefined keys #3

New Issue

Dennis · 2018-07-25T22:48:30Z

Dennis commented

2018-07-25 22:48:30 +00:00

In the original repository and in our implementation so far, all keys that are not explicitly defined during a write operation are purged. So, if a user writes to pedal 0 without explicitly defining the values of pedal 1 and 2, the latter are purged.

We should fix this and add a separate del_key command.

E.g.

Situation before:

 ┌──────────────────────────────────────────────────────────────┐
 │                       Programmed Keys                        │
 ╞══════════════════════════════════════════════════════════════╡
 │         0          │         1          │         2          │
 ├──────────────────────────────────────────────────────────────┤
 │         A          │         B          │         C          │
 └──────────────────────────────────────────────────────────────┘

Command:

sudo ./footswitch-rs write -c wr_key -p 0 -v E

Situation after:

 ┌──────────────────────────────────────────────────────────────┐
 │                       Programmed Keys                        │
 ╞══════════════════════════════════════════════════════════════╡
 │         0          │         1          │         2          │
 ├──────────────────────────────────────────────────────────────┤
 │         E          │      < None >      │      < None >      │
 └──────────────────────────────────────────────────────────────┘

In the [original repository](https://github.com/rgerganov/footswitch) and in our implementation so far, all keys that are not explicitly defined during a write operation are purged. So, if a user writes to pedal 0 without explicitly defining the values of pedal 1 and 2, the latter are purged. We should fix this and add a separate `del_key` command. E.g. Situation before: ```bash ┌──────────────────────────────────────────────────────────────┐ │ Programmed Keys │ ╞══════════════════════════════════════════════════════════════╡ │ 0 │ 1 │ 2 │ ├──────────────────────────────────────────────────────────────┤ │ A │ B │ C │ └──────────────────────────────────────────────────────────────┘ ``` Command: ```bash sudo ./footswitch-rs write -c wr_key -p 0 -v E ``` Situation after: ```bash ┌──────────────────────────────────────────────────────────────┐ │ Programmed Keys │ ╞══════════════════════════════════════════════════════════════╡ │ 0 │ 1 │ 2 │ ├──────────────────────────────────────────────────────────────┤ │ E │ < None > │ < None > │ └──────────────────────────────────────────────────────────────┘ ```

Dennis self-assigned this 2018-07-25 22:48:30 +00:00

Dennis added the

feature

label 2018-07-25 22:48:30 +00:00

Dennis referenced this issue from a commit

2018-11-14 00:30:37 +00:00

Added beginning of function to preserve settings This is the beginning of a solution to issue #3. Right now, it is only able to preserve keys. In a later commit, modifiers, mouse settings, etc. will be added as well.

Dennis referenced this issue from a commit

2018-11-23 17:50:45 +00:00

Finished do-not-purge feature. Closes #3 This feature is not yet tested on the Append:: functions since not all functions are yet implemented. As soon as they get implemented, this feature will be verified on them as well. Furthermore, a Clear function is added. Finally, in this commit, mouse_left, mouse_right, mouse_middle, and mouse_double got abbreviated to left, right, middle, and double.

Dennis closed this issue

2018-11-23 17:50:45 +00:00