Handle direct messaging correctly #2

New Issue

Dennis · 2019-01-13T10:15:19Z

Dennis commented

2019-01-13 10:15:19 +00:00

At this moment, the bot creates a room with new users. This should be a a direct room:

{
    "content": {
        "@bob:example.com": [
            "!abcdefgh:example.com",
            "!hgfedcba:example.com"
        ]
    },
    "type": "m.direct"
}

When looking for a room to send a private message in with send_message_private_public(), the room does not check whether a room is a direct room or not.

- [x] At this moment, the bot creates a room with new users. This should be a a direct room: ```json { "content": { "@bob:example.com": [ "!abcdefgh:example.com", "!hgfedcba:example.com" ] }, "type": "m.direct" } ``` - [x] When looking for a room to send a private message in with `send_message_private_public()`, the room does not check whether a room is a direct room or not.

Dennis self-assigned this 2019-01-13 10:15:19 +00:00

Dennis added the

enhancement

label 2019-01-13 10:15:19 +00:00

Dennis referenced this issue from a commit

2019-01-19 23:43:49 +00:00

Add custom Matrix Python SDK. Solves #5 and #2 This commit releases a custom Matrix Python SDK. This means that the most important classes---MatrixClient, Room, and MatrixHttpApi---are inherited by Custom classes. This enables us to change behaviour or add new features in a well structured and predictable way. The first issue that is solved with this new custom SDK is the problem that was introduced in #2.

Dennis commented

2019-01-19 23:44:56 +00:00

The second item is not added in 9e139a0f3e. It does not matter whether a room is marked private or not. If there is a room with only the requesting user and the bot, it can be used. It would not make sense to open yet another room.

The second item is *not* added in 9e139a0f3ee67fd363c7ffc6e62c7a6aa47c2204. It does not matter whether a room is marked private or not. If there is a room with only the requesting user and the bot, it can be used. It would not make sense to open yet another room.

Dennis closed this issue

2019-01-19 23:45:05 +00:00

Sign in to join this conversation.